Skip to content

🐛 Fix envtest process stop on Windows#3519

Open
gologames wants to merge 1 commit into
kubernetes-sigs:mainfrom
gologames:fix-envtest-stop-windows
Open

🐛 Fix envtest process stop on Windows#3519
gologames wants to merge 1 commit into
kubernetes-sigs:mainfrom
gologames:fix-envtest-stop-windows

Conversation

@gologames
Copy link
Copy Markdown

@gologames gologames commented May 15, 2026

Fixes #3518

This adds a Windows-specific signalProcess implementation for envtest process teardown.

On Windows, os.Process.Signal does not support SIGTERM / SIGKILL, so Environment.Stop() fails when stopping the local kube-apiserver and etcd processes.

The Windows implementation uses process.Kill() instead.

This does not provide full Windows process-tree semantics like Unix process-group signaling. A Windows Job Object would be needed for that. However, in the current envtest setup, kube-apiserver and etcd are started directly via exec.Command. Killing those direct child processes fixes the current teardown failure.

Tested with an envtest admission webhook suite on Windows.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented May 15, 2026 •
edited
Loading

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: gologames / name: gologames (6149bda)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 15, 2026

Welcome @gologames!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 15, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gologames
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 15, 2026

Hi @gologames. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 15, 2026
@dongjiang1989
Copy link
Copy Markdown
Member

dongjiang1989 commented May 19, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanford joelanford Awaiting requested review from joelanford

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Envtest Fails to Stop Control Plane on Windows

3 participants

@gologames @k8s-ci-robot @dongjiang1989